department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
40 stars 61 forks source link

text-input component implementation of character count varies between USWDS and VADS #2519

Open emilytaylorux opened 7 months ago

emilytaylorux commented 7 months ago

Bug Report

What happened

There are some discrepancies between the Storybook USWDS text-input component and the component on the USWDS site.

USWDS version vs USWDS version in Storybook

What I expected to happen

They should function similarly

Reproducing

Steps to reproduce:

  1. USWDS version vs USWDS version in Storybook

Urgency

How urgent is this request? Please select the approriate option below and/or provide details

caw310 commented 7 months ago

@emilytaylorux please provide more details.

humancompanion-usds commented 7 months ago

Emily Slacked me about this. I'll just add what she provided:

In Figma, the text-input box appears to follow the USWDS component. There are also some discrepancies between the Storybook USWDS component and the component on the USWDS site.

USWDS: character countdown, red alert at max Storybook USWDS: character countdown, no red alert at max

We'll evaluate whether we want to follow the USWDS implementation here or not. It's odd to me that it allows you to enter more text. I'm not sure that is necessary nor what the advantages of that interaction are. I also don't know if there is any evidence that their implementation is superior.