department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
51 stars 62 forks source link

[Progress bar] Progress bar component audit #257

Closed CrystabelReiter closed 2 years ago

CrystabelReiter commented 4 years ago

Description:

There are 2 types of progress bars on design.va.gov

Progress bars (specifically the segmented progress bar) in the sketch library, design.va.gov, and react library are out of sync.

You can view the component in design.va.gov and in the react library separated into the progress bar and segmented progress bar

These are the ways this component is not synced

React library:

Design.va.gov:

joshkimux commented 3 years ago

@CrystabelReiter @caw310 as part of this audit, would we also be able to review its accessibility as well? @AngelaFowler82 wrote up a ticket recently on why the progressbar shouldn't have a tabindex=0

joshkimux commented 3 years ago

Linking this to the unresolved accessibility ticket #9226 as well

bkjohnson commented 2 years ago

@GnatalieH here's that update on the components used in app code.

ProgressBar

The <ProgressBar> React component is used in two files:

image


SegmentedProgressBar

The <SegmentedProgressBar> React component is also only used in two files:

Forms library

This is the top navigation that's seen on all forms pages, like in the screenshot above

Letters

image

caw310 commented 2 years ago

Closing as the team did an audit in Q2 2022.