search

department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
37 stars 57 forks source link

Deprecate Number Input #2609

Open micahchiang opened 5 months ago

micahchiang commented 5 months ago

Description

The va-number-input component has incrementally expanded in function to the point where there is little difference between the purpose it serves and that which our va-text-input fills. Even now, issues exist for requests to broadened the abilities va-number-input offers. With this, the va-number-input will be deprecated, and it's existing functionality will be subsumed by the va-text-input.

This is a multi-step process that will involve:

  1. Updating the va-text-input component with any va-number-input functionality it doesn't already cover
  2. Updating the storybook guidance for va-text-input
  3. Providing teams with a timeline and migration plan for when va-number-input will be replaced in vets-website
  4. Releasing the update to vets-website.

Considerations:

jamigibbs commented 3 months ago

@micahchiang We may need another task for the forms library to do this deprecation. This mapping for VaTextInputField will need whatever new props added to it that were brought over from number input (currency for example).

This was brought in in Slack here