department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
36 stars 55 forks source link

De-duplicate instances of components per app in comp-usage script #2687

Open Andrew565 opened 2 months ago

Andrew565 commented 2 months ago

Currently and by way of example, if a component appears in an app and that app's sub-app, such as applications/mhv and applications/mhv/secure-messaging, it gets counted twice by the component-usage script; once for each app. This ticket seeks to resolve this by improving the way component instances get counted so that they will appear only once, for the sub-app.

For example, a VaRadioOption react-binding component that shows up in applications/mhv/secure-messaging will count as an instance for that app, but will not count as an instance for the applications/mhv app.

Details

The component-usage script is comprised of two files within the component-library/packages/design-system-dashboard-cli/src directory: create-spreadsheets.js and find-ds-components.js. This ticket will require updating the counting mechanism within create-spreadsheets.js only.

Acceptance Criteria

caw310 commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc