department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
36 stars 55 forks source link

Add `aria-expanded` and `aria-controls` attributes/functionality to va-button #2752

Open jerekshoe opened 3 weeks ago

jerekshoe commented 3 weeks ago

Bug Report

What happened

When attempting to add aria-expanded and aria-controls attributes to the button inside the va-button component, the attributes are not applied. These attributes are needed for screen readers

Chrome inspector

Screenshot 2024-04-22 at 5 20 24 PM

Element being inspected

Screenshot 2024-04-22 at 5 21 47 PM

What I expected to happen

I expected that the button in the shadow DOM would have the aria-expanded and aria-controls attributes so that screen readers could function properly when encountering this element

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

Details

caw310 commented 3 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc

jamigibbs commented 3 weeks ago

I'm just adding a link to the Slack conversation about this design in case it will help us prioritize the work. It sounds like the usage of button in this design context may be removed or deprecated in the next few months.