department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
60 stars 65 forks source link

DST Staging Review (Consider): Possible color contrast improvements #2835

Open shiragoodman opened 6 months ago

shiragoodman commented 6 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Design System Staging Information

Component: Button Icon Staging Review ticket: Staging Review: Design System Button Icon Component

Findings details

The details of this ticket are for consideration only. No Staging Review issue was found. High-priority: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

There are a few color combinations that meet WCAG AA requirements but might be able to meet AAA with a minor tweak. This isn't strictly necessary, but meeting those higher contrast standards is a definite nice-to-have.

Note that there's a bigger contrast issue for the :hover and :focus states for cancel and delete addressed in another ticket.

Recommended action

I think it's worth exploring some darker shades to see if you can get over 7:1. It looks like --vads-color-secondary-dark is tantalizingly close with a 6.98:1 ratio against white.

References


Next Steps for DST

caw310 commented 6 months ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc