department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
36 stars 55 forks source link

Visually hidden breadcrumbs are still able to be tabbed to/focused on #2837

Open laflannery opened 2 weeks ago

laflannery commented 2 weeks ago

Bug Report

What happened

On mobile and small screens, I was confused because I was able to tab to/focus on breadcrumb elements that are not visually displaying. It seems as though these elements have simply been moved off the scren using CSS instead of actually being hidden which is what is causing this.

What I expected to happen

I would expect that I should be able to visually visually see everything that I am focusing on. Focusing on or being able to tab to a non-visual element is going to cause confusion for keyboard and visual-sr users.

Reproducing

Steps to reproduce:

  1. On page that is using the v3 breadcrumbs, the facility locator for example, view this on a small screen/mobile view so you can only see the the single "VA.gov home" breadcrumb
  2. Use your keyboard to start tabbing through the interactive elements
  3. Notice that you are able to tab to and focus on this single visible breadcrumb
  4. Tab again
  5. Notice that the visible focus ahs disappeared but if you notice in the lefthand corner of the screen, you are actually focusing on the second breadcrumb, for the current page.

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

Details

This bug is not blocking work but it is an accessibility bug that is going to cause confusion for various user groups - keyboard and screen reader users on small screens/mobile or zoomed in.

I also found the corresponding bug ticket in the USWDS repo if this helps at all

caw310 commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc