Breadcrumbs - Update breadcrumbs liquid filter to support lang attribute

micahchiang commented 4 months ago

Description

This should be done after #2868. We have an open PR in content build where an accessibility issue was surfaced regarding the lang attribute. Ticket #2868 was done to add support for the lang attribute in va-breadcrumbs. This ticket should update the above pull request so it can be merged.

Considerations

Work done in this ticket should use the branch associated with this pull request
Original comment highlighting the issue
Slack conversation around the issue
lang values are determined through this existing liquid filter

Tasks

[ ] Update the drupal liquid filter and/or the breadcrumb liquid template so lang is passed in as a prop.

Acceptance Criteria

[ ] Above tasks have been completed
[ ] Sitewide team has verified the issue has been resolved in the above pull request

caw310 commented 4 months ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc

Andrew565 commented 3 months ago

This will carry over due to accessibility feedback needing to be incorporated into the breadcrumbs component, which means that the liquid filter updates will not be reviewable until the breadcrumbs component updates are released.

Andrew565 commented 2 months ago

This will carry over again due to not being able to get the updated component-library release out soon enough for the sitewide reviewers to have due time to review the changes before the end of the sprint.

department-of-veterans-affairs / vets-design-system-documentation