Open cmmerrill opened 3 months ago
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rmessina1010 @rsmithadhoc
@cmmerrill I think this might be an implementation issue. Do you have a link to where this is located in the vets-website codebase?
The va-date
component requires the error
prop to be set in order to display an error message. When I inspect the page, I don't see the error prop active:
Here is an example of how the error
prop should be set:
reference: https://design.va.gov/storybook/?path=/docs/components-va-date--docs#error
@jamigibbs Carissa is no longer on our team. I'm going to loop @laflannery in to assist with your questions.
I actually was searching the DST backlog to see if a bug existed for a layout issue I was seeing with this component. @jamigibbs let me know if this is a separate issue.
@jamigibbs I found it in the file here (lines 17-25) and it doesn't have the error
prop you mentioned so this makes sense.
However I do have one other question - I do see an error message when I focus out of these fields - click out instead of using the filter button - is that a separate thing that doesn't come from the error
prop?
I actually was searching the DST backlog to see if a bug existed for a layout issue I was seeing with this component. @jamigibbs let me know if this is a separate issue.
@aklausmeier hmmm... that looks like a separate issue. 🤔 I didn't see anything in the backlog for that either. It would be great if you could create an issue for it with your screenshot. Thank you!
@jamigibbs going to have our engineers inspect as a first pass, will spin up a DST bug ticket if needed, TY!
@jamigibbs @aklausmeier The alignment issue in error state happens in Storybook also. I created a bug ticket for it here: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3113
Bug Report
What happened
What I expected to happen
Reproducing
Steps to reproduce:
Urgency
How urgent is this request? Please select the appropriate option below and/or provide details
Details