department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
37 stars 57 forks source link

Allow ability to exclude H2s from On the page component #2956

Open laflannery opened 2 months ago

laflannery commented 2 months ago

Bug Report

What happened

The On this page component currently pulls every H2 on the page into the table of contents and there isn't a way to exclude specific H2s if needed. We have a use case where we would like to add the Summary box above the OtP but this would cause a poor user experience because the anchor link would take the user UP the page instead of down.

What I expected to happen

We would like the ability to exclude specific H2s from the OtP component so that if there is an H2 above the component, there isn't a chance of a user selecting a link and moving up the page.

Reproducing

Steps to reproduce:

1. 2. 3. 4.

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

Details

Screenshot of what we are proposing: The link "What type of services do Vet Centers provide?" is the link that would take the user up instead of down: Screenshot 2024-06-24 at 9 03 04 AM

This bug is not entirely blocking work in progress but it does introduce undesirable behavior. We are going to go forward because this work does have stakeholder priority attached to it

caw310 commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc

laflannery commented 2 months ago

@caw310 If this ticket gets worked on, is it possible to review/work on this related ticket in tandem? It's something that continuously surfaces in the VA Automated AMP scans and would be good to move forward if possible CC: @artsymartha68

caw310 commented 2 months ago

@laflannery we will evaluate when we are going to pull this ticket into a sprint.

laflannery commented 2 months ago

Thanks! CC: @aklausmeier for awareness

aklausmeier commented 4 weeks ago

This is also occurring on VBA Portland with an alert.

Screenshot 2024-08-15 at 2 35 14 PM Screenshot 2024-08-15 at 2 35 20 PM