department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
39 stars 58 forks source link

[Design] Determine button line height #2984

Closed babsdenney closed 2 months ago

babsdenney commented 3 months ago

Description

You can read the background about this ticket in the development ticket below.

Update button line height #2963

We need to determine a new line height for buttons so that the button text doesn't run together. Once a new line-height is determined, update Figma and dev ticket with the new line height.

Details

Button in Figma Button in Storybook

Tasks

Acceptance Criteria

caw310 commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @babsdenney @danbrady @LWWright7

LWWright7 commented 2 months ago

@danbrady @babsdenney - This is ready for review. I used the USWDS spacing for guidance and created examples to show what the button would look like with spacing at the USWDS breakpoints (1, 1.15, 1.35, 1.5, 1.62, 1.75 and I added 2 just for funzies).

danbrady commented 2 months ago

Really great work, @LWWright7! I like how you laid out the options and used USWDS as a guide.

LWWright7 commented 2 months ago

This ticket is blocked by a research ticket for dev: 3088

LWWright7 commented 2 months ago

Closing this ticket as the line height has been determined through research into USWDS breakpoints in this ticket:

Screen Shot 2024-07-25 at 10 32 27 AM

I've created a new ticket to actually update Figma component depending on the research that the dev team does in this ticket.