department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
37 stars 57 forks source link

Add icon to suffix for va-text-input web component - Development #3063

Closed caw310 closed 3 weeks ago

caw310 commented 1 month ago

Description

Add the ability to have an icon as a suffix in the va-text-input web component. USWDS guidance for input includes prefix and suffix so we should match that. https://designsystem.digital.gov/components/input-prefix-suffix/

Tasks

Acceptance Criteria

caw310 commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rmessina1010 @rsmithadhoc

harshil1793 commented 1 month ago

This task is already completed. Here is the prod storybook.

caw310 commented 1 month ago

Great. I will close this ticket since suffix is added.

jamigibbs commented 1 month ago

I think there is a misunderstanding about what needs to be done still. This ticket was created from @danbrady's comment yeterday here:

After discussing with Matt, we should stay aligned with the USWDS for this component. So while they don't show examples for suffix icon, it is possible to achieve with their component. They also have the following documentation:

Use text or icons. Input prefixes and suffixes can accept either plain text or icons.

So VADS should have the same features.

Right now, the component does not accept both plain text or icons for both prefix and suffix so we need to add that functionality still for suffix I believe.

Can you verify that @harshil1793?

harshil1793 commented 1 month ago

@caw310 I saw Dan's comment, and it seems like we need this ticket to add support for an icon suffix for the va-text-input. Can I update the description if you're okay with that?

caw310 commented 1 month ago

@harshil1793 Yes update the ticket as needed. Thanks!