department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
59 stars 65 forks source link

[Design] Research margin & gutter spacing sitewide #3111

Open LWWright7 opened 3 months ago

LWWright7 commented 3 months ago

Duplicate check

This update is for:

Pattern

What is the name?

spacing tokens / margins & gutters

What is the nature of this update?

What problem does this solve?

All across the VA.gov site there are multiple different values for margin spacing and gutter spacing throughout the entire site. This makes it extremely difficult for designers to create mockups that "match code". Not to mention the inconsistency does not align with the overall goal of site unity.

Additional Context

### Tasks
- [ ] Search Slack for discussions about margin / spacing
- [ ] Discuss spacing/margins/gutters with a dev/the dev team
- [ ] Come up with standard margin & gutter values (aka normalize) and create tokens for them in Figma for mobile, tablet and desktop
- [ ] Create tickets for updates to: 1) Figma 2)documentation 3)dev ticket(s)
caw310 commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @babsdenney @danbrady @LWWright7

danbrady commented 3 months ago

This looks good to me. After the values are decided, do we want to include updating the doc site and/or any templates as part of this effort? Or make new ticket(s)?

LWWright7 commented 3 months ago

@danbrady I think there would be a new ticket to incorporate these values into Figma, also one for documentation and finally one (or multiple) to address the issue on the dev side.

LWWright7 commented 3 months ago

@danbrady I added a task to create those tickets to the list above