department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
60 stars 65 forks source link

Make sure links in Header/Footer that are the same have the same HREF #3175

Open laflannery opened 1 year ago

laflannery commented 1 year ago

Status

[2024-08-08] [Fran] This will be a DST ticket, since they are going to/are componentizing the header/footer. Will either transfer ticket, or share info so they can open their own ticket and then close this one. [2024-08-05] [Fran] Pinged Randi and Chris in Slack about async refining when they have a moment [2024-06-03] Decided during prefinement meeting that refinement of this ticket will be async to attempt to provide estimate. [2024-05-30] The Federal Header/Footer refresh is no longer happening; revisit this ticket to determine viability. [1/25/2024] This will be work done after the 'new' Federal header/footer work is done, which is blocked on OFCIO research/disposition.

Description

Automated accessibility tools flag issues where they find the same link text but different HREFs. This is a valid error but the tools take it very seriously. For example, they consider https://www.va.gov/find-locations/ and https://www.va.gov/find-locations two different HREFs (because one doesn't have the end /). When we do the header/footer redesign, I want to be sure that links within the header and footer that are the same don't have this issue anymore just so I don't have to deal with these false positives.

I believe there are only 2 links this applies to:

Acceptance Criteria

Team

Please check the team(s) that will do this work.

FranECross commented 5 months ago

@laflannery Per Dave Conlon, the Federal Header/Footer improvement effort has been closed by the Whitehouse / 18f. In light of that, it seems we should correct the existing issues and not close this ticket? Thanks in advance!

FranECross commented 5 months ago

Will async refinement to determine estimate if possible.

caw310 commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rmessina1010 @rsmithadhoc