department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
37 stars 57 forks source link

Radio Button: Stray aria-describedby points to an ID that doesn't exist #3225

Closed davidakennedy closed 1 day ago

davidakennedy commented 3 weeks ago

Bug Report

What happened

On our Higher Level Review form, maintained by the Decision Reviews team, we're seeing some stray aria-describedby attributes that point to an ID that doesn't exist. This shows up when you have an optional description for the radio button. It looks like this:

<span class="usa-radio__label-description dd-privacy-hidden" data-dd-action-name="description" aria-describedby="option-label">VA may contact me by mail, telephone, email, or another way to schedule my conference.</span>

Note the extra aria-describedby="option-label" but that option-label doesn't exist.

This also happens in one of the Storybook demos.

What I expected to happen

We wouldn't expect the aria-describedby to show up if something it points to isn't present.

Reproducing

Steps to reproduce:

  1. View the Storybook demo.
  2. Note the extra aria-describedby="option-label" but that option-label doesn't exist.

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

Details

Screenshot from the Higher Level Review form:

Screen from Higher Level Review form with aria-describedby="option-label" but that `option-label` doesn't exist.

caw310 commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rmessina1010 @rsmithadhoc