department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
40 stars 61 forks source link

Unauth/Drupal Expandable Alert does not match Design System #3407

Open mgleo opened 1 week ago

mgleo commented 1 week ago

Bug Report

What happened

The expandable alert on auth (Drupal) pages does not match the Design System: Alert - Expandable. It includes an additional grey and blue link that expands the content. See "Learn how to get temporary debt relief" in screenshot.

Unauth Expandable Alert (Does not match design system): Image

Auth Expandable Alert (Does match design system): Image

What I expected to happen

The expandable alert on unauth (Drupal) pages should match what is on the Design System and on auth pages.

Reproducing

Steps to reproduce:

  1. Go to https://www.va.gov/manage-va-debt/ to view the unauth version
  2. Sign in on http://staging.va.gov using user81's login. Navigate to https://staging.va.gov/manage-va-debt/summary to view the auth version

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

Details

mgleo commented 1 week ago

cc @denisecoveyduc

micahchiang commented 3 days ago

Hey @mgleo - I think there's some misunderstanding with component use here. Based on the unauth'd page you linked to, and the first screenshot, I did some digging and it looks like this page is using a va-alert component with a nested va-additional-info component: Image

This is distinctly different than a va-alert-expandable component.

You may want to consider refactoring the code that corresponds to the above screenshot into a va-alert-expandable component if that is your desired behaviour.

mgleo commented 3 days ago

Hi @micahchiang, Thank you for looking into this. The screenshot and code you are showing is from a unauthenticated Drupal page that our team doesn't have the ability to edit. I believe @laurwill is selecting this option from CMS within Drupal. I'm not able to see the CMS but I believe @laurwill stated that va-alert-expandable component was not available. How are components added to Drupal CMS?

ccing @laurwill and @Dr-Pongo and @denisecoveyduc