department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
40 stars 61 forks source link

Update va-breadcrumb in development template #3417

Open rsmithadhoc opened 3 days ago

rsmithadhoc commented 3 days ago

Bug Report

What happened

From a support request:

There was recently a change to breadcrumbs.html in content-build which author Andrew Steele brought to the attention of affected apps on vets-website. Our team made the recommended fix of changing a query selector from '.va-nav-breadcrumbs' to 'va-breadcrumbs'. However, when running vets-website locally, it uses dev-template.ejs to format breadcrumbs instead of content-build. It looks like this dev-template.ejs file will need to be updated to match the changes to breadcrumbs.html in content-build. Can we request this change be made? Thank you!

Link to change to content-build Link to dev-template file

What I expected to happen

va-breadcrumb updated in the dev template

Reproducing

Steps to reproduce:

  1. Run vets-website with pages using dev-template.ejs

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

caw310 commented 3 days ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rmessina1010 @rsmithadhoc