department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website

https://design.va.gov

37 stars 57 forks source link

Create Signature component #344

Closed rebeccawalsh closed 11 months ago

rebeccawalsh commented 3 years ago

Feature Request

[x] I’ve searched for any related issues and avoided creating a duplicate issue.

Is this feature request relating to an existing component or utility? Please describe.

Do you have a suggestion for a new component or utility?

Component suggestion: official signature / attestation pattern for forms system. Currently being used on the 1010, and we are duplicating their design on the Financial Status Report form (5655).

Explicit attestations seem relatively common in VA forms, so establishing a standard for this would help with consistency going forward.

Additional context

rebeccawalsh commented 3 years ago

Images not appearing in original request :( 10-10CG:

5655:

CrystabelReiter commented 3 years ago

Final decision from Design System council meeting on 12/4/20: We've decided that this would be a helpful component to add to the forms system. This will be added to the design system team backlog @rebeccawalsh One piece of feedback from the council - We recommend to not hide the component under the accordion but to have it be separate like in the caregiver example. We'll note this in future documentation

rebeccawalsh commented 3 years ago

@CrystabelReiter Cool! Good golly, I didn't even realize it wasn't nested in the Caregiver example. Thanks! I thought I had copied it :P

CrystabelReiter commented 3 years ago

@caw310 Can we add this to the design system team backlog?

caw310 commented 3 years ago

Will do.

CrystabelReiter commented 3 years ago

Update before my departure:

Templates are in sketch for teams: https://www.sketch.com/s/89d435c3-75e4-42c3-ad53-dc364c78b3fd

Documentation draft: https://design.va.gov/patterns/form-templates-update

When development and staging review are done:

[x] Update any templates and documentation with accessibility, design, content feedback
[ ] Add templates to the sketch library - update symbols to use the ones from the library
[x] Delete current form templates page. Update title on the update page from form-templates-update to form-templates. Publish draft
[ ] Announce to teams

humancompanion-usds commented 1 year ago

This work was not completed. While we do have a signature pattern in the Design System, we do not, to my knowledge, have a component anywhere. Thus I'm reopening.

@ndsprinkle - Can you comment here on what we do have in Forms library, if anything? I believe we may have built this in 26-4555. Did we build it as a reusable widget or component? Or could that code be used as a start for a web-component?

ndsprinkle commented 1 year ago

@humancompanion-usds We have

Attestation: https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/platform/forms-system/src/js/components/Attestation.jsx

which consumes FormSignature: https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/platform/forms-system/src/js/components/FormSignature.jsx

so it is in the forms libary and is re-usable, but it didn't line up with the mockups for our form (26-4555), so I had to do an in house solution.

Also, from what I can tell, nothing uses either of these components. Because of that, we could safely update these components to be in-line with the design system without messing up any existing forms.

humancompanion-usds commented 1 year ago

As we discussed today I'd like our team to contribute the signature component that is documented in the Design System as a web-component which we'll then bring into the Forms library.

humancompanion-usds commented 11 months ago

This is superseded by issues #1886 and #2092