department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
59 stars 65 forks source link

Upgrade component-library to use node 20 #3484

Open ataker opened 3 weeks ago

ataker commented 3 weeks ago

Description

Upgrade node version to 20

Details

This PR introduced unused unit tests. These tests couldn't be used because our current version of node, 18, does not support the type File natively.

If node 20 can't be upgraded to, please add a polyfill to support File in the tests in va-file-input-multiple.spec.todo.ts.

Tasks

Acceptance Criteria

ataker commented 3 weeks ago

In a test run through upgrading to node 20, the only issue I ran into was in packages/react-components/scripts/build.js, line 18 return new Buffer( needed to be updated to return Buffer.from( as calling new Buffer has been deprecated

ataker commented 3 weeks ago

PR from the last time node was upgraded