department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website

https://design.va.gov

59 stars 65 forks source link

Add tab design to Storybook #403

Open allison0034 opened 3 years ago

allison0034 commented 3 years ago

Feature Request

[ ] I’ve searched for any related issues and avoided creating a duplicate issue.

Is this feature request relating to an existing component or utility? Please describe.

Component/utility name: We currently do not have any documentation around using tabs in Sketch or Storybook. Tabs have come through the collaboration cycle a couple of times and it would be good to add them to our system.

Do you have a suggestion for a new component or utility?

VAOS has tested and added tabs to their appointments screens. 4f411635-4e28-4353-95a3-012e41a1d2ed

Additional context

caw310 commented 3 years ago

Issue was discussed in DSC meeting on 3/12. Decision made to Add tabs component with very limited usage. Put in backlog for DST to finalize as a component with a11y work Trevor mentioned.

caw310 commented 3 years ago

Ticket created to create documentation for tab. https://app.zenhub.com/workspaces/vsp-design-system-5f8de67192551b0012ebb802/issues/department-of-veterans-affairs/va.gov-team/21469

caw310 commented 3 years ago

Discussed at the 3/12 DSC meeting. Here is the follow up:

Add tabs component with very limited usage.
Fine putting in DS that we do not recommend w/ exception of following decisions. Recommend using X instead (ie On this page)
Put in backlog for DST to finalize as a component with a11y work Trevor mentioned.
DST to create tickets for this work. (Carol)