department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
38 stars 57 forks source link

Add 'Delete file' and 'Add another' buttons to Sketch file form review section #417

Open allison0034 opened 3 years ago

allison0034 commented 3 years ago

Feature Request

Is this feature request relating to an existing component or utility? Please describe.

Do you have a suggestion for a new component or utility? No

Additional context

Screen Shot 2021-03-30 at 10 30 42 AM Screen Shot 2021-03-30 at 11 29 41 AM
caw310 commented 3 years ago

@CrystabelReiter , let's try to fit this in when you have time.

humancompanion-usds commented 11 months ago

@allison0034 - This issue is admittedly quite old, but I'll try to address it. This is what we have in Sketch: https://sketch.com/s/c8df169f-5b02-4999-befb-34c7b3b62ba9

This pattern doesn't cover uploading an attachment and thus neither does the pattern in Sketch. But I see in the screenshot that it is a valid variation. Do you know where we are doing this so I can go have a look?

allison0034 commented 11 months ago

I confirmed the "Add another" is now in the review page for the list and loop.

Screen Shot 2023-10-12 at 1 07 20 PM
allison0034 commented 11 months ago

Same for the delete file. I checked the 21-526EZ.

Screen Shot 2023-10-12 at 1 10 52 PM
caw310 commented 7 months ago

@danbrady @LWWright7 is this fixed in Figma? If so let's close this issue.

LWWright7 commented 6 months ago

@caw310 This can be closed after I complete this ticket, during this sprint. Right @danbrady ??

danbrady commented 6 months ago

Yes, I believe so. However, if any steps have a file upload we'll need to circle back to it once the updated File Input component (with the drop zone and optional card) is created. If you see that in any of the patterns, please add it to an issue so we can track it. Thanks!

LWWright7 commented 6 months ago

@danbrady Will do! Thanks!

caw310 commented 6 months ago

@caw310 This can be closed after I complete this ticket, during this sprint. Right @danbrady ??

Yes you can close this onc eyou're done with the other ticket. Thanks.

humancompanion-usds commented 5 months ago

I don't think this is done. What this originally asked for was showing how we handle list and loop patterns, like Service History, in the Review page in a form. We could do that in one of the following ways:

  1. Add a template for the [Help users to check answers] pattern which shows the Review template in various states and include list and loop as one of those.
  2. Do the same as above but instead just add on to the current Review page template annotated example.
  3. Add an example in Service History that depicts how that shows up on the Review page.

I think #2 or #1 are the way to go.

humancompanion-usds commented 1 month ago

@danbrady - Can you review this issue and see if this has been handled and if not get it slated for an upcoming sprint with @caw310 ? Thanks.