department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
40 stars 61 forks source link

Cards - Pattern update #600

Closed GnatalieH closed 2 years ago

GnatalieH commented 2 years ago

Feature Request

This update is for:

What is the name

Cards - Pattern

What is the nature of this update?

Additional Context

Update draft of Cards based on feedback from Design System Council on 12/10/21. This includes creating wireframe/minified examples of Status card, Promo card, and Appointment card.

GnatalieH commented 2 years ago

Updated draft of Cards is ready for review.

humancompanion-usds commented 2 years ago

This isn't published yet so reopening.

humancompanion-usds commented 2 years ago

This blocks issue #644. I'd like us to define the variations of Card that we're going to document as components. The ask in #644 is create a web-component that would produce some variations. @GnatalieH - I think you had done this somewhere and now I can't find it again. I recall seeing a list of 2-3 variations of Cards perhaps in a Sketch file.

caw310 commented 2 years ago

@humancompanion-usds , here is a link to the draft for you to review and sign off. https://design.va.gov/patterns/cards

@GnatalieH please include link to Sketch file.

GnatalieH commented 2 years ago

@humancompanion-usds here is a link to a Sketch file I started a few months ago where I began mocking up some designs for a Card component. At the time, Ryan wasn't overly concerned with including image thumbnails in cards, although our "promo" card uses an image. But, that's why my designs don't include an image thumbnail version.

humancompanion-usds commented 2 years ago

@GnatalieH - Good work! The Example cards for status and appointment are great variations to get into the system. I think the anatomy of a Card that you did is great and you probably did more than is necessary with all of the annotated versions. We may not need all of those for the documentation.

Now looking at this again I'm leaning toward making this a Component rather than a Pattern. While there are lots of variations we should enumerate them as you have done here and capture them into the system. This Experimental Pattern seems like a likely candidate that we could update to talk about how to use the Card components in certain contexts and to use actual examples rather than illustrative fake content examples: https://design.va.gov/experimental-design/authenticated-info-list

So action items:

humancompanion-usds commented 2 years ago

Some requests that came up during our research sessions with designers:

caw310 commented 2 years ago

Linking to an old request for Card pattern from 2020. https://app.zenhub.com/workspaces/design-system-council-backlog-629783f797297600151c16b5/issues/department-of-veterans-affairs/vets-design-system-documentation/256

humancompanion-usds commented 2 years ago

We have shipped Card! Happy day. https://design.va.gov/components/card

Sketch is also updated and gets a "starred" release today.