Open rmessina1010 opened 2 years ago
@rmessina1010 , this is on the agenda for the Design System Council meeting on Friday, Feb 18. You should get an invite to the meeting which we hope you can attend.
Need to define variations of cards we will support before we work on this.
@rmessina1010 - I'm going back through our DSC requests and trying to figure out where some of them are at. We've just added a va-card component and some additional examples. Some questions for you:
@danbrady is working on this here: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2447 Dan and Ray to discuss this.
@humancompanion-usds, @caw310
Not exactly, I noted that CTA had varied appearances and compositions, ranging from simple inline buttons to step outlines; It also depends on whether the user is logged in ( which USUALLY defaults to a sign in prompt ). There would have to be some logic behind this. My proposal, at the time it was written, was meant as a way for VFS teams to show intent. Please note, that widgets also had a placeholder div around them containing data attributes, I at the time of my proposal I was thinking this could be consolidated if a va-cta element was created.
I noticed, when following up this question that a lot of the instances in content-build have changed or disappeared from the code. I will check further on this and add updated images/examples.
Code reference:
<div data-template="paragraphs/react_widget" data-entity-id="59360" data-widget-type="form-686-CTA" data-widget-timeout="20">
<div>
<va-alert visible="true" status="continue" class="hydrated">
<h3 slot="headline">Sign in to add or remove dependents</h3>
<div>
<p>Sign in with your existing <strong>Login.gov</strong>, <strong>ID.me</strong>, <strong>DS Logon</strong>, or <strong>My HealtheVet</strong> account. If you don’t have any of these accounts, you can create a free <strong>Login.gov</strong> or <strong>ID.me</strong> account now.</p>
<va-button text="Sign in or create an account" uswds="false" class="hydrated"></va-button>
</div>
</va-alert>
</div>
</div>
For clarity, I am suggesting an aggregate component, to account for the variety displayed above.
Story:
As a developer, I need to be able to output content of a Call To Action Widget, provided in various parts, in a consistent manner and compliant with the VA Design System.
What
Add a Web component to create and standardize Call To Action Widgets and allow for usage in static and React pages.
Why
Many CTA’s follow the same output pattern but approach it in various directions. Creating a web component for CTAs would standardize the rendering process and help consolidate how CTAs are created. This, in turn, will facilitate making their functionality. more granular and ultimately allow to hoisting CTA (and possibly all widgets) up from being sub components of the static-page app.
Anything else
Expected Params:
The primary set of props provided will include, but is not limited to, a subset of the following:
Appearance
Visually this should appear no different than a VADS Button / Action Link / Process-List / Anchor Link ( or any combination there of) and will implement existing VA Web Component practices.
Discovery Notes:
[https://vfs.atlassian.net/wiki/spaces/~96033397/pages/2078801963/CTA+Widget+Evaluation+Recommendation](Discovery Notes for context)
Suggested logic