search

department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
37 stars 56 forks source link

[Accordion] Fix va-accordion-item test #728

Open k80bowman opened 2 years ago

k80bowman commented 2 years ago

Description

The "fires a custom event when the location hash matches the accordion id" test for the va-accordion-item component has started to fail intermittently. You can see details about what is going on and what fixes have been tried in this Slack thread.

Notes

It seems to fail on CI but not locally (or at least it has not failed locally yet). You can see it failed on this run.

Acceptance Criteria

pdavies88 commented 2 years ago

expect(await accordionItemToggled).toHaveReceivedEventTimes(1); we need to await the expect to help prevent test completing prior to event firing properly

pdavies88 commented 2 years ago

Ticket is to fix test: https://github.com/department-of-veterans-affairs/component-library/blob/5ea718b56c9c0a167a89b2fce9c07d4a931d12df/packages/web-components/src/components/va-accordion/va-accordion-item.e2e.ts#L160

bkjohnson commented 2 years ago

I left a comment in a Stencil ticket describing our problem and asking about steps to resolve it.

caw310 commented 1 year ago

@Andrew565 is this still an issue? Can we close this?

Andrew565 commented 1 year ago

This is still needed.

micahchiang commented 10 months ago

Closing the PR since it's almost 2 years old at this point, but dropping a link to reference it for future work - https://github.com/department-of-veterans-affairs/component-library/pull/246