department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
238 stars 123 forks source link

Card / type change leading change? #2373

Closed emilyville closed 8 years ago

emilyville commented 8 years ago

I'm wondering if we merged a few things simultaneously and our leading got a little snug in the cards?

Before: screen shot 2016-05-17 at 9 58 00 pm

After: screen shot 2016-05-17 at 9 57 51 pm

Drakenhart commented 8 years ago

The titles look fine, but the description text may not do so well with the leading reduction. I also like the increased padding, it gives better visual breathing room.

One curiosity: Why would you want to snug up the leading on the smaller text?

Veterans come from all walks of life, and age as anyone else does. The larger portion of the population (until they age out) are older veterans who may have weaker vision due to age and/or other complications due to their service. (Glaucoma for example). Even younger vets will eventually grow older and all of our body parts start having issues over time, including our eyes.

When the leading, especially on longer words, gets scrunched together more it stops looking like letters and starts looking like general shapes. So it gets difficult to distinguish what the word-form is, and hard to determine via context from reading bits of the other word-forms.

A good test of this (a trick I learned years ago from a professor):

Can you read it? If not it may need a touch more leading and/or size increase.

ahelkit commented 8 years ago

@Drakenhart thanks for your feedback and tips! I think this was a bug. We're loosening back the line-height of the headings and keeping the leading of the smaller text as is. You can find the pull request here.