Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
[x] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
[ ] Yes, I'm removing, renaming or moving a folder
Summary
In the FAQ for the SM Landing page, one of the accordions was coded as two
elements. This change combines separate the
elements into one
Related issue(s)
MHV-63940 - Error in the accordion code on the landing page
Slack thread for multiple lines in compiled html from jsx string interpolation
Medical Records worked on a solution but their solution might not be the solution here. I highly recommend reading over the thread and/or contacting other developers in this thread who has worked on this in the past.
Where to find this issue
Error in the accordion code on the landing page (From Duke's audit)
Emergency contact information.
Issue: Unordered list that appears in the accordion heading “What if I have an emergency or an urgent question?“ is broken up into two lists.
Severity: Low
Recommendation: Create one list out of two. A similar accordion appears on the Medical Records landing page and is coded correctly.
Feature Flag Y/N ?
DataDog Analytics Y/N ?
Manual Testing Y/N ? Y-Rakesh
Automated Testing Y/N
Accessibility Testing Y/N ? Y-Bobby
UCD Validation Y/N N
Acceptance Criteria:
AC1 One list has been created and follows design in medications
Testing done
Describe what the old behavior was prior to the change
Describe the steps required to verify your changes are working as expected
Describe the tests completed and the results
_Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
[ ] Browser console contains no warnings or errors.
[ ] Events are being sent to the appropriate logging solution
[ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
Authentication
[ ] Did you login to a local build and verify all authenticated routes work as expected with a test user
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Summary
elements. This change combines separate the- elements into one
Related issue(s)
MHV-63940 - Error in the accordion code on the landing page
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Va.gov - Secure Messaging
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?