fix depends for array builder

[rhasselle-oddball]

Summary

• Fix depends for array builder and add index property

depends: (formData, index) => ... 

• Fix forward navigation not respecting newly updated values for all arrays

Related issue(s)

• Link to ticket created in va.gov-team repo department-of-veterans-affairs/va.gov-team-forms#1800 department-of-veterans-affairs/va.gov-team-forms#1888

Testing done

• Unit, cypress, regression, browser

Screenshots

n/a

What areas of the site does it impact?

array builder depends.

Acceptance criteria

Quality Assurance & Testing

• [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• [ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• [ ] Linting warnings have been addressed
• [ ] Documentation has been updated (link to documentation *if necessary)
• [ ] Screenshot of the developed feature is added
• [ ] Accessibility testing has been performed

Error Handling

• [ ] Browser console contains no warnings or errors.
• [ ] Events are being sent to the appropriate logging solution
• [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• [ ] Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[williamphelps13]

I switched out the onNavForward and onNavBack conditional page solution in this file, for the depends solution locally and it is working nicely!

The issue I am still encountering is that on edit if the page becomes no longer shown the data is still present. See this in the following video when "wrist fracture" triggers the sideOfBody question but then on edit when "wrist fracture" is updated to "asthma" which does not trigger the sideOfBody the sideOfBody data is still present and "asthma" is displayed as "asthma, right":

https://github.com/user-attachments/assets/0162d64d-f227-46dc-8559-d46300b693f6

Could be out of scope for this fix or could be I need to handle it in a different way.

[rhasselle-oddball]

Thanks @Midge-dev for helping with the tests on 686

Status update: Working on bug that @williamphelps13 found. Need to fix that before merging.

[rhasselle-oddball]

Previous bug: when dependent page is the last page and its the last item added the user could not continue on from the list loop This is now resolved.

Potential new issue: the recent changes appear to have changed formData to contain all formData for onNavForward when it previously only contained the itemData.

This may be an enhancement actually because it seems desirable that formData always contain all formData and never just contain itemData.

Appreciate the thorough testing @williamphelps13 - I'll spend some more time on this, to make sure the formData discrepancies don't cause regressions in existing forms.