VACMS-16191 Add test coverage for Resources & Support app

[randimays]

Are you removing, renaming or moving a folder in this PR?

• [x] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
• [ ] Yes, I'm removing, renaming or moving a folder

:warning: TeamSites :warning:

Did you change site-wide styles, platform utilities or other infrastructure?

• [x] No
• [ ] Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

The Resources & Support app had some opportunities for unit test coverage and a Cypress suite.

Unit tests

Notes:

• I moved a bunch of functions from within a useEffect to the outer scope so they could be unit tested easily. The functionality of the application should not have changed at all.
• We are limited a lot in unit tests by our inability to interact with web components and the shadow DOM. This is largely mitigated by the Cypress test suites

Before

After

Cypress

Our Cypress suite has:

• A suite for both desktop and mobile (separately)
• Validation for the inputs including open/closed search area on mobile
• Checking correct text and URLs for results
• Validation for correct pagination
• Checking correct display for search terms with no results
• Checking a sitewide search (as well as the default R&S search)

Related issue(s)

https://github.com/department-of-veterans-affairs/va.gov-cms/issues/16191

Testing done

Tested the app manually locally and ran all unit and Cypress tests. No functionality should have changed so I didn't add screenshots here.

What areas of the site does it impact?

/resources and /resources/search

Quality Assurance & Testing

• [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• [x] Linting warnings have been addressed

Error Handling

• [x] Browser console contains no warnings or errors.

[jilladams]

@randimays this is the only open Sitewide vets-website PR I see right now. Once you move out of Draft, can you confirm if Curt's notes in devops channel are correct that you are able to merge with just a team approval, and not Platform approval?

[randimays]

@jilladams Confirmed that I was able to merge this with only Chris's approval because the changes were siloed to the src/applications folder. A lot of our work crosses over into the src/platform folder so we have to wait on Platform when that happens (example).