department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
242 stars 126 forks source link

CST - update CST workspace component-library from version 43.0.2 to 48.0.2 due to upload … #33123

Closed pmclaren19 closed 1 week ago

pmclaren19 commented 1 week ago

Summary

We created a workspace in https://github.com/department-of-veterans-affairs/vets-website/pull/33036 pr but the changes were not being merged into Staging.

Found this platform doc about workspaces and realized we were missing our dependency in the nohoist section so we added that but we still weren't seeing our changes in staging.

After investigating @micahchiang found that the component-library 43.0.2 version that we were setting in the workspace was being overridden buy the root folder and we needed to update content-build for the claim status app to have "useLocalStylesAndComponents": true so the version in our workspace was being used so we did that here.

Tested these changes and found that when uploading a .txt file or .jpg file it is adding it as a .pdf file for some reason.

https://github.com/user-attachments/assets/d5311601-705b-473f-81a8-f455c6306853

https://github.com/user-attachments/assets/bc121a8d-4354-45e9-a39d-701e576f0ebd

Since this seems like a larger issue then the initial bug and I am unable to reproduce this bug in my dev env created this ticket to roll our workspace version of the component-library back to 48.0.2

Related issue(s)

Testing done

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Desktop Screenshot 2024-11-20 at 6 04 52 AM Screenshot 2024-11-20 at 6 05 10 AM

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

pmclaren19 commented 1 week ago

After further investigation found that this issue is a backend thing and was happening before our initial changes with this ticket so we do not need to roll the component-library back. The Light house API updates files received to be pdfs. Closing this ticket.