[97179] Add helper method unit tests to Appoint a Representative - Githubissues

department-of-veterans-affairs / vets-website

Frontend for VA.gov

Creative Commons Zero v1.0 Universal

242 stars 125 forks source link

[97179] Add helper method unit tests to Appoint a Representative #33138

Closed jvcAdHoc closed 1 day ago

jvcAdHoc commented 3 days ago

Are you removing, renaming or moving a folder in this PR?

[x] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
[ ] Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

[x] No
[ ] Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

This pr removes unused helper methods
This pr removes some commented out imports
This pr adds unit tests to helper methods

Related issue(s)

97179

Testing done

went through the flow locally to double check no noticeable change to the app

What areas of the site does it impact?

Appoint a Representative Forms 21-22 and 21-22a: there should be no impact

Acceptance criteria

Quality Assurance & Testing

[x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
[ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
[ ] Linting warnings have been addressed
[ ] Documentation has been updated (link to documentation *if necessary)
[ ] Screenshot of the developed feature is added
[ ] Accessibility testing has been performed

Error Handling

[ ] Browser console contains no warnings or errors.
[ ] Events are being sent to the appropriate logging solution
[ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

[x] Did you login to a local build and verify all authenticated routes work as expected with a test user