department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
242 stars 125 forks source link

88477 Welcome component: use preferred name from user profile #33183

Open nichia opened 1 day ago

nichia commented 1 day ago

Are you removing, renaming or moving a folder in this PR?

:warning: TeamSites :warning:

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Use the Preferred name attribute that was recently added to the /v0/user API (sourced from the MPI preferred_name).

This PR:

Related issue(s)

Testing done

Screenshots

Screenshots are expected to remain the same:

Before After
Mobile Screenshot 2024-11-22 at 10 55 01 AM Screenshot 2024-11-22 at 10 06 21 AM
Desktop Screenshot 2024-11-22 at 10 55 39 AM Screenshot 2024-11-22 at 10 05 37 AM

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback