department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
242 stars 125 forks source link

discharge-wizard: convert .feature to va-summary-box #33185

Open jamigibbs opened 1 day ago

jamigibbs commented 1 day ago

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

:warning: TeamSites :warning:

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

The .feature class is deprecated in favor of the va-summary-box web component.

Related issue(s)

Testing done

visually inspected locally

Screenshots

before

before

after

after

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

jilladams commented 7 hours ago

@chriskim2311 FYI in case this means we need to change anything in the DUW re-build as subtask pattern to correspond to this PR.