department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
242 stars 126 forks source link

added threadId prop to ReplyForm from MessageReply #33194

Closed KyleCardwell closed 10 hours ago

KyleCardwell commented 5 days ago

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

Summary

Related issue(s)

MHV-61588 - User unable to move conversation when a reply draft is started

User unable to move conversation when a reply draft is started

GIVEN A user navigates to a thread AND Clicks reply button and "Continue to reply" on interstitial page AND A reply draft message textbox appears AND Regardless whether a draft is started, saved or not saved WHEN A user clicks Move button, proceeds with a folder selection and confirms moving a thread THEN An error banner is displayed "We’re sorry. We couldn’t load this page. Try again later." AND User is unable to move a thread

API request does not receive a proper thread ID in a request. Example: https://staging-api.va.gov/my_health/v1/messaging/threads/undefined/move?folder_id=3888068

Feature Flag Y/N ?

DataDog Analytics Y/N ?

Manual Testing Y/N ? Y-Rakesh

Automated Testing Y/N Y-Fazil

Accessibility Testing Y/N Y-Bobby

UCD Validation Y/N N

Acceptance Criteria:

AC1 User is able to move the thread in the above scenario

Testing done

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?