department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
242 stars 126 forks source link

[VAMC-19449]Situation Updates Static Banner #33221

Closed SnowboardTechie closed 19 hours ago

SnowboardTechie commented 2 days ago

Are you removing, renaming or moving a folder in this PR?

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Related issue(s)

Testing done

Screenshots

Screenshot 2024-11-07 at 10 21 02 AM

enshots

What areas of the site does it impact?

This is interacting with a header level feature so it has the potential for sitewide impact

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

SnowboardTechie commented 1 day ago

Not sure when it happened but a previously working test introduced by this PR is no longer functioning correctly. I'll investigate and address this prior to attempting a merge

SnowboardTechie commented 1 day ago

@randimays @rsmithadhoc thank you for the OG reviews. Unfortunately, there was a test adjustment I missed when handling previous PR feedback. I introduced one simple commit to handle this https://github.com/department-of-veterans-affairs/vets-website/pull/33221/commits/194eb78ea864eff1f186edae86a4030d7c7fe236 If you have a chance today would you mind doing one more review please?