Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
[x] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
[ ] Yes, I'm removing, renaming or moving a folder
If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).
If an entry for this folder exists in content-build and you are:
Deleting a folder:
First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
Add the link to your merged vets-website PR here
Then, Delete the application entry in registry.json and merge that PR before this one
Add the link to your merged content-build PR here
Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).
:warning: TeamSites :warning:
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.
Did you change site-wide styles, platform utilities or other infrastructure?
[x] No
[ ] Yes, and I used the proxy-rewrite steps to test the injected header scenario
Summary
A minor change to the hook (setting the loading status outside the try block) and complete unit tests for the hook.
Related issue(s)
Link to ticket created in va.gov-team repo
department-of-veterans-affairs/va.gov-team#97724
Testing done
Created unit tests
What areas of the site does it impact?
Community Care referral scheduling feature in VAOS
Acceptance criteria
[ ] The hook is unit tested
[ ] Tests pass
Quality Assurance & Testing
[ ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
[ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
If the folder you changed contains a
manifest.json, search for itsentryNamein the content-build registry.json (theentryNamethere will match).If an entry for this folder exists in content-build and you are:
Deleting a folder:
vets-websitefor all instances of theentryNamein yourmanifest.jsonand remove them in a separate PR. Look particularly for references insrc/applications/static-pages/static-pages-entry.jsandsrc/platform/forms/constants.js. If you do not do this, other applications will break!Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).
:warning: TeamSites :warning:
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websitesSlack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
A minor change to the hook (setting the loading status outside the try block) and complete unit tests for the hook.
Related issue(s)
Testing done
Created unit tests
What areas of the site does it impact?
Community Care referral scheduling feature in VAOS
Acceptance criteria
Quality Assurance & Testing
Error Handling