departurerb / departure

Percona's pt-online-schema-change runner for ActiveRecord migrations.
Other
141 stars 53 forks source link

Move CI from Travis CI (org) to GitHub Actions #66

Closed sikachu closed 3 years ago

sikachu commented 3 years ago

Departure is currently only set up to build on travis-ci.org, which was the preferred place for open source projects to run tests on their projects. However, it was shut down at the end of May and we're required to move to travis-ci.com which comes with only 10,000 build credits per month.

However, as Departure is an open-source project hosted on GitHub, we have access to unlimited builds on GitHub Actions, which is a CI/CD offering from GitHub.

From my perspective, I think this is the right time to make a switch to GitHub Actions so we can continue to have CI coverage on the project.

This PR introduces GitHub Workflow configuration for Departure, which is based on the Travis CI configuration file. I, however, omitted Code Climate test reporting part, as I do not have access to the secret key required to set it up. However, you can follow the instructions to set it up again at https://docs.codeclimate.com/docs/github-actions-test-coverage.

Note that after this PR is merged we'll start seeing that currently master is failing. I've submitted #65 to fix one of the global spec failures, but we'll still need to address another failure on Rails 6.1.

sikachu commented 3 years ago

You can see current builds on my fork at the moment: https://github.com/sikachu/departure/actions

I forgot to mention in the PR description, but currently the only check we're seeing on PR is from Code Climate which doesn't actually run the test. I believe this gave us a false positive that nothing broke while add_index is currently broken on Rails 6.1 (#61)