When a job is started with the azure provider, git_source credentials are provided for the dev.azure.com domain and that URL is ultimately used to clone the repo.
If a repo has a submodule and specifies the URL with the dev.azure.com format, everything is OK because the credentials are properly injected by the proxy, but there is an alternate format that's not handled: org.visualstudio.com/DefaultCollection/project/_git/repo and if a submodule clone is attempted with that URL, it's not detected as being functionally the same as the other URL and a 401 is returned, possibly making the job fail due to missing sources.
This PR adds the alternate org.visualstudio.com credentials.
A manual test was performed, first with the old behavior ensuring the 401 and again with the new behavior ensuring a correct 200 when cloning the submodule.
When a job is started with the
azureprovider,git_sourcecredentials are provided for thedev.azure.comdomain and that URL is ultimately used to clone the repo.If a repo has a submodule and specifies the URL with the
dev.azure.comformat, everything is OK because the credentials are properly injected by the proxy, but there is an alternate format that's not handled:org.visualstudio.com/DefaultCollection/project/_git/repoand if a submodule clone is attempted with that URL, it's not detected as being functionally the same as the other URL and a401is returned, possibly making the job fail due to missing sources.This PR adds the alternate
org.visualstudio.comcredentials.A manual test was performed, first with the old behavior ensuring the
401and again with the new behavior ensuring a correct200when cloning the submodule.