Closed cyril-s closed 2 years ago
Any updates on this? getting the same thing makes it much harder to use dependabot.
It seems like this is currently only an issue on GitLab. As we're a small team we're currently relying on community contributions for anything but GitHub, but we would welcome a PR that resolves this for GitLab.
The logic around branch naming lives here. One options I see is we could give that a max_length
option, and set it to 255
for GitLab?
@jurre any chance you could check the PR here?
https://github.com/dependabot/dependabot-core/pull/5338 is now merged. But I think a follow-on PR is needed to set this arg to 255
for GitLab?
I'm unclear if that value should be set here in dependabot-core
or in the external entrypoints (typically for GitLab I think that's https://github.com/dependabot/dependabot-script or https://gitlab.com/dependabot-gitlab/dependabot). We're trying to avoid adding more platform-specific logic into dependabot-core
, so the entrypoints are preferred if possible... but I haven't looked at how the wrappers actually load dependabot-core
to see how easy that is.
If the best place to set this is external, then this issue can be closed from the perspective of dependabot-core
... otherwise happy to review the follow-on PR.
cc @nudded @TomNaessens as you may know more?
@jeffwidman yes, we'll be fixing that upstream in the dependabot-gitlab
repository, so only the configuration was needed, no specific value needs to be set in dependabot-core
For anyone following, dependabot-gitlab
v0.30.0 is released which contains this option: https://gitlab.com/dependabot-gitlab/dependabot/-/releases/v0.30.0
Package manager/ecosystem ruby:bundler
What you expected to see, versus what you actually saw When dependabot tried to create a merge request in gitlab, API responded with:
The ref is perfectly fine, but branch name length exceeds ext4 255 file name char limit, which prevent git from creating a branch: