dependabot / dependabot-core

🤖 Dependabot's core logic for creating update PRs.
https://docs.github.com/en/code-security/dependabot
MIT License
4.63k stars 990 forks source link

`automerge` label is not being added to PRs #4217

Open Maxim-Mazurok opened 3 years ago

Maxim-Mazurok commented 3 years ago

dependabot.yml content

version: 2
updates:
  - package-ecosystem: 'npm'
    directory: '/'
    schedule:
      interval: 'weekly'
      day: 'saturday'
      time: '10:00'
      timezone: 'Australia/Sydney'
    labels:
      - 'dependencies'
      - 'automerge'

What you expected to see, versus what you actually saw I expected dependabot to open PR with automerge label, as per config Images of the diff or a link to the PR, issue or logs https://github.com/Maxim-Mazurok/google-api-typings-generator/pull/551 (had to add automerge label manually)

Maxim-Mazurok commented 3 years ago

I imagine it's because it's a kinda "reserved" label. In which case, dependabot probably should warn/throw when it sees it in config?

jeffwidman commented 2 years ago

Thanks for raising this. Agree we should either warn during config file validation or we should remove automerge from the reserved label list since we intentionally don't currently support automerge. If we could do the latter, than we could allow folks to use the GitHub actions workaround for automerging with a label like automerge. But I haven't poked at the code yet, so not sure what's possible...

github-actions[bot] commented 1 day ago

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

Maxim-Mazurok commented 1 day ago

unstale