dependabot / dependabot-core

🤖 Dependabot's core logic for creating update PRs.
https://docs.github.com/en/code-security/dependabot
MIT License
4.65k stars 1k forks source link

package-lock files with version 3 are not handled correctly by Dependabot #4361

Closed ferferga closed 1 year ago

ferferga commented 2 years ago

We recently upgraded to Node 16 and the lockfile version 3 of package-lock.json (the version without backwards-compatible features of the lockfile, see docs here, as we want to enforce always the most current features with the latest LTSs).

Lockfiles proposed by dependabot have massive changes, even when recreated or rebased

Package ecosystem npm Package manager version npm 8.1.0 Language version

Relevant PRs

cedric-anne commented 2 years ago

I confirm the issue. Same problem on this PR: https://github.com/glpi-project/glpi/pull/10035 .

jeffwidman commented 1 year ago

Closing, as I think this was fixed by the bump to NPM 8:

Please comment if I'm misreading/misunderstanding something, and we can re-open.

cedric-anne commented 1 year ago

Indeed, it seems to be OK now.