Revisit how responsibilities are split up between `UpdateChecker` and `Version` in docker ecosystem

dependabot / dependabot-core

🤖 Dependabot's core logic for creating update PRs.

https://docs.github.com/en/code-security/dependabot

MIT License

4.73k stars 1.02k forks source link

Revisit how responsibilities are split up between `UpdateChecker` and `Version` in docker ecosystem #5911

Open deivid-rodriguez opened 2 years ago

deivid-rodriguez commented 2 years ago

Currently version parsing logic is split between these two classes, and it feels like it should probably be unified into the Version class. It should be reviewed at some point.

_Originally posted by @mattt in https://github.com/dependabot/dependabot-core/pull/5886#discussion_r995981733_

jeffwidman commented 2 years ago

I was chatting with @pavera about this last week and he mentioned something that's probably related to this refactoring.

Essentially that many ecosystems do a "find if there's a valid update available" which then passes to the next stage in the pipeline "yes, we should update"... so then the next step does a "okay, we know we can update, so now go lookup what version we should update to and then perform the update"... so we end up repeating the update lookup twice, which is network intensive + resolver intensive, both of which can be very slow.

github-actions[bot] commented 4 weeks ago

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.