Open jsoref opened 2 years ago
Agreed, we should detect if possible whether the close event that triggered this comment was generated by a "Fixes #" comment in another PR, and skip this comment in that case.
Also affected by this. It gives this comment when I merge a dependabot PR with a non-fast-forward merge if I'm not using the merge button on GitHub. It's quite annoying and noisy. https://github.com/panda3d/panda3d/pull/1697
Dependabot could just load the new version and check if the version updates were applied, right?
Is there an existing issue for this?
Package ecosystem
github-actions
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
.github/workflows/x.yml
:dependabot.yml content
Updated dependency
What you expected to see, versus what you actually saw
Another user created a PR which subsumed this PR.
It included the same change. Their PR included a
closes #...
notation.When they created the PR, a
When they merged the PR, a
Dependabot responded by saying:
It should have checked to see if the goal it was trying to achieve was still relevant, if the dependency was either updated to match (or surpass) its goal, or was removed entirely, it should have provided some other message acknowledging that its services were no longer needed, but not suggesting that it be told to ignore things for this.
Native package manager behavior
A human would not say "oh, you could tell me not to pay attention to this anymore", that's what the
closes
and closed in merged PR notations tell humans.Images of the diff or a link to the PR, issue, or logs
Smallest manifest that reproduces the issue
No response