search

dependabot / dependabot-core

🤖 Dependabot's core logic for creating update PRs.
https://docs.github.com/en/code-security/dependabot
MIT License
4.69k stars 1.01k forks source link

[github-actions] dependabot not updating https://github.com/Swatinem/rust-cache #7384

Closed tamird closed 1 year ago

tamird commented 1 year ago

Is there an existing issue for this?

Package ecosystem

github-actions

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

There are a few affected manifests in aya-rs/aya: https://github.com/search?q=repo%3Aaya-rs%2Faya%20Swatinem%2Frust-cache&type=code, and one in aya-rs/bpf-linker: https://github.com/aya-rs/bpf-linker/blob/7847c0b2959ca517779ff569ef0d231e6734fad8/.github/workflows/build-test.yml#L39-L40

dependabot.yml content

https://github.com/aya-rs/aya/blob/main/.github/dependabot.yml

Updated dependency

https://github.com/Swatinem/rust-cache (v1 vs v2)

What you expected to see, versus what you actually saw

I expected an update, but none happened.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

Drarig29 commented 1 year ago

We have a similar issue, where we recently set up dependabot to work on 2 repositories with the exact same dependabot.yml file, and only one repository had dependabot pull requests opened.

This file was recently updated with v3 for checkout and setup-node:

https://github.com/DataDog/datadog-ci-azure-devops/blob/25703a397130d0ff50bac161eb0f49574fe1aac5/.github/workflows/unit-tests.yml

But this file (in a different repository) did not, although they are very similar:

https://github.com/DataDog/synthetics-ci-github-action/blob/dd7049d88a128ad2c01fe567792ab2a25f918eef/.github/workflows/unit-tests.yml

Is there a way to see dependabot's debug logs?

tamird commented 1 year ago

@Drarig29 I think your issues are caused by a separate problem (which I also have seen in https://github.com/aya-rs/bpf-linker/pull/47): your repo contains multiple different workflows, and some of them reference checkout@v2 while others reference checkout@v3: https://github.com/search?q=repo%3ADataDog%2Fsynthetics-ci-github-action%20actions%2Fcheckout&type=code.

You can see the dependabot logs for your repo at https://github.com/DataDog/datadog-ci-azure-devops/network/updates - click on the "last checked ..." link.

It's probably worth finding that log (it will contain some errors) and reporting a separate bug. I should have done that - now that I manually bumped the dep in https://github.com/aya-rs/bpf-linker/pull/47, my old log is gone.

Drarig29 commented 1 year ago

You can see the dependabot logs for your repo at https://github.com/DataDog/datadog-ci-azure-devops/network/updates - click on the "last checked ..." link.

Oh, thanks I would never have found it!

It really looks like https://github.com/dependabot/dependabot-core/issues/7214, I'll put a comment there, and ask to reopen the issue.

deivid-rodriguez commented 1 year ago

This should be fixed now. If you have not workaround this issue, feel free to check for updates now and it should properly create PRs 👍.

Drarig29 commented 1 year ago

@deivid-rodriguez it worked, thank you!

tamird commented 1 year ago

Something is still broken here. See https://github.com/aya-rs/book/blob/1d8358605da867bd0223fc1799fa051e562ad0ca/.github/workflows/ci.yml#L35 -- that's not a case of mixed versions, it's just not updating that action for some reason. Here's the log:

  proxy | 2023/06/27 15:00:09 proxy starting, commit: e11a9091e6d61fc45afc46a500c4b9a417032297
  proxy | 2023/06/27 15:00:09 Listening (:1080)
updater | 2023-06-27T15:00:10.668611507 [685013691:main:WARN:src/devices/src/legacy/serial.rs:222] Detached the serial input due to peer close/error.
updater | time="2023-06-27T15:00:14Z" level=info msg="guest starting" commit=d75d20dab6a6f4d2e41a889226843d222ca6a812
updater | time="2023-06-27T15:00:14Z" level=info msg="starting job..." fetcher_timeout=10m0s job_id=685013691 updater_timeout=45m0s updater_version=a56bdcd7de17911b74ddd5f1bda43074be45661c-github-actions
updater | 2023/06/27 15:00:17 INFO Raven 3.1.2 ready to catch errors
updater | 2023/06/27 15:00:20 INFO <job_685013691> Starting job processing
  proxy | 2023/06/27 15:00:20 [002] GET https://api.github.com:443/repos/aya-rs/book
  proxy | 2023/06/27 15:00:20 [002] * authenticating github api request with token for api.github.com
  proxy | 2023/06/27 15:00:21 [002] 200 https://api.github.com:443/repos/aya-rs/book
  proxy | 2023/06/27 15:00:21 [004] GET https://api.github.com:443/repos/aya-rs/book/git/refs/heads/main
  proxy | 2023/06/27 15:00:21 [004] * authenticating github api request with token for api.github.com
  proxy | 2023/06/27 15:00:21 [004] 200 https://api.github.com:443/repos/aya-rs/book/git/refs/heads/main
  proxy | 2023/06/27 15:00:21 [006] GET https://api.github.com:443/repos/aya-rs/book/contents/?ref=1d8358605da867bd0223fc1799fa051e562ad0ca
  proxy | 2023/06/27 15:00:21 [006] * authenticating github api request with token for api.github.com
  proxy | 2023/06/27 15:00:21 [006] 200 https://api.github.com:443/repos/aya-rs/book/contents/?ref=1d8358605da867bd0223fc1799fa051e562ad0ca
  proxy | 2023/06/27 15:00:21 [008] GET https://api.github.com:443/repos/aya-rs/book/contents/.github/workflows?ref=1d8358605da867bd0223fc1799fa051e562ad0ca
  proxy | 2023/06/27 15:00:21 [008] * authenticating github api request with token for api.github.com
  proxy | 2023/06/27 15:00:21 [008] 200 https://api.github.com:443/repos/aya-rs/book/contents/.github/workflows?ref=1d8358605da867bd0223fc1799fa051e562ad0ca
  proxy | 2023/06/27 15:00:21 [010] GET https://api.github.com:443/repos/aya-rs/book/contents/.github/workflows/ci.yml?ref=1d8358605da867bd0223fc1799fa051e562ad0ca
  proxy | 2023/06/27 15:00:21 [010] * authenticating github api request with token for api.github.com
  proxy | 2023/06/27 15:00:21 [010] 200 https://api.github.com:443/repos/aya-rs/book/contents/.github/workflows/ci.yml?ref=1d8358605da867bd0223fc1799fa051e562ad0ca
updater | 2023/06/27 15:00:21 INFO <job_685013691> Finished job processing
updater | time="2023-06-27T15:00:21Z" level=info msg="task complete" container_id=job-685013691-file-fetcher exit_code=0 job_id=685013691 step=fetcher
updater | 2023/06/27 15:00:23 INFO Raven 3.1.2 ready to catch errors
updater | 2023/06/27 15:00:25 INFO <job_685013691> Starting job processing
  proxy | 2023/06/27 15:00:25 [012] GET https://github.com:443/actions/checkout.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [012] * authenticating git server request (host: github.com)
  proxy | 2023/06/27 15:00:25 [012] 200 https://github.com:443/actions/checkout.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [014] GET https://github.com:443/dtolnay/rust-toolchain.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [014] * authenticating git server request (host: github.com)
  proxy | 2023/06/27 15:00:25 [014] 200 https://github.com:443/dtolnay/rust-toolchain.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [016] GET https://github.com:443/swatinem/rust-cache.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [016] * authenticating git server request (host: github.com)
  proxy | 2023/06/27 15:00:25 [016] 200 https://github.com:443/swatinem/rust-cache.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [018] GET https://github.com:443/actions/setup-python.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:25 [018] * authenticating git server request (host: github.com)
  proxy | 2023/06/27 15:00:26 [018] 200 https://github.com:443/actions/setup-python.git/info/refs?service=git-upload-pack
updater | 2023/06/27 15:00:26 INFO <job_685013691> Starting update job for aya-rs/book
updater | 2023/06/27 15:00:26 INFO <job_685013691> Checking all dependencies for version updates...
updater | 2023/06/27 15:00:26 INFO <job_685013691> Checking if actions/setup-python 4 needs updating
  proxy | 2023/06/27 15:00:26 [024] GET https://github.com:443/actions/setup-python.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:26 [024] * authenticating git server request (host: github.com)
  proxy | 2023/06/27 15:00:26 [024] 200 https://github.com:443/actions/setup-python.git/info/refs?service=git-upload-pack
updater | 2023/06/27 15:00:26 INFO <job_685013691> Latest version is 4
updater | 2023/06/27 15:00:26 INFO <job_685013691> No update needed for actions/setup-python 4
updater | 2023/06/27 15:00:26 INFO <job_685013691> Checking if actions/checkout 3 needs updating
  proxy | 2023/06/27 15:00:26 [026] GET https://github.com:443/actions/checkout.git/info/refs?service=git-upload-pack
  proxy | 2023/06/27 15:00:26 [026] * authenticating git server request (host: github.com)
  proxy | 2023/06/27 15:00:26 [026] 200 https://github.com:443/actions/checkout.git/info/refs?service=git-upload-pack
updater | 2023/06/27 15:00:26 INFO <job_685013691> Latest version is 3
updater | 2023/06/27 15:00:26 INFO <job_685013691> No update needed for actions/checkout 3
updater | 2023/06/27 15:00:27 INFO <job_685013691> Finished job processing
updater | time="2023-06-27T15:00:27Z" level=info msg="task complete" container_id=job-685013691-updater exit_code=0 job_id=685013691 step=updater

Notice that the other actions (checkout, setup-python) both log something like Latest version is 4, but that doesn't happen for https://github.com/Swatinem/rust-cache.

deivid-rodriguez commented 1 year ago

Thanks for letting us know @tamird. #7494 should fix this.