Closed bmulholland closed 6 months ago
Grouped update PR for my frontend repo did not have this bug, FYI. (That one is in the GA runner beta, though.)
We're seeing this too.
In the logs I see Error while generating commit message: no implicit conversion of Symbol into Integer
:
updater | 2024/04/11 10:23:34 ERROR <job_813197460> Error while generating PR message: no implicit conversion of Symbol into Integer
proxy | 2024/04/11 10:23:34 [708] GET https://api.github.com:443/repos/aws/aws-sdk-ruby/contents/gems/aws-sdk-s3?ref=version-3
proxy | 2024/04/11 10:23:34 [708] * authenticating github api request with token for api.github.com
proxy | 2024/04/11 10:23:34 [708] 200 https://api.github.com:443/repos/aws/aws-sdk-ruby/contents/gems/aws-sdk-s3?ref=version-3
updater | 2024/04/11 10:23:34 ERROR <job_813197460> Error while generating commit message: no implicit conversion of Symbol into Integer
updater | 2024/04/11 10:23:36 INFO <job_813197460> Finished job processing
updater | 2024/04/11 10:23:36 INFO Results:
updater | +---------------------------------------------------------------------------------------------------------------------------------------------------------+
updater | | Changes to Dependabot Pull Requests |
updater | +------------------------------+--------------------------------------------------------------------------------------------------------------------------+
updater | | closed: dependencies_changed | aws-sdk-s3,excon,pg,sequel,rubocop,rubocop-rspec |
updater | | created | aws-sdk-s3 ( from 1.143.0 to 1.146.1 ), excon ( from 0.109.0 to 0.110.0 ), pg ( from 1.5.5 to 1.5.6 ), rake ( from 13... |
updater | +------------------------------+--------------------------------------------------------------------------------------------------------------------------+
updater | time="2024-04-11T10:23:36Z" level=info msg="task complete" container_id=job-813197460-updater exit_code=0 job_id=813197460 step=updater
I've also been experiencing this for a few weeks (npm packages). I have seen this error in the most recent log:
updater | 2024/04/15 07:13:42 ERROR <job_814572336> Error while generating PR message: Passed `nil` into T.must
@jakecoffman Hi! Just checking you'd seen this issue? It's a pretty serious regression that started almost 2 weeks ago now.
It's been happening a lot longer than 2 weeks for me. I've seen this in repos from November 2022, March 2023, July 2023, and more recently including this week.
edit: Example from Nov 2022:
In #5980 we started handling errors around PR metadata gathering. The idea was the PR change is still good, we shouldn't hold up creating it because we couldn't generate the PR body.
As a result of that we lost error reporting to the service, so there may be new bugs around metadata generation that we're not seeing in our error reporting. I think a good first step on this is to start reporting the exception to the service again so we can prioritize and fix them.
I'll see if I can round up someone to wire it back up.
This happened again to me in a public repo (https://github.com/dhensby/readable-tokens/pull/148)
Flagging that this is happening for me as well. Here's a number of Dependabot PR's this is happening on for me:
What seems to be a side effect, is that I can no longer run the @dependabot ignore
command either.
Dependabot simply doesn't react to any form of the ignore
operation (with/without major/minor doesn't make a difference).
I am assuming the ignore
job fails because there are no dependencies named in the PR?
Would be great if this could be solved soon! The mentioned PR's are all failing because ignored dependencies aren't taken into account anymore.
Thanks for the examples, we're on it 👍
I am assuming the ignore job fails because there are no dependencies named in the PR?
I wouldn't think that's related, we don't rely on any of the information from the PR body itself, it's purely used for presentation logic. I'll make sure to double check they're not caused by the same underlying problem though.
I probably didn't fix everyone's issues with https://github.com/dependabot/dependabot-core/pull/9560 but I think I fixed a common one. For everyone else who experiences this, we should now get a stacktrace in the logs which should make it much easier to track down the problem if you notice it again. Open a new issue in that case if you can!
I also opened #9564 to track reporting the errors to the service so we can catch regressions like this in the future.
@jakecoffman Thank you for the update. Retriggering Dependabot on one of our repos now I see the same issue on the new grouped PR it just created (with the same exception mentioned in https://github.com/dependabot/dependabot-core/issues/9457#issuecomment-2049391693, except now with a stacktrace) - I filed #9565 for this.
Is there an existing issue for this?
Package ecosystem
Bundler
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
No response
Updated dependency
No response
What you expected to see, versus what you actually saw
Usually dependabot lists out all the upgraded packages and provides info about the changed versions, but this week, nothing:
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response