[paperwork] take node: prefix as indicator for being a core module

dependents / node-precinct

Unleash the detectives

MIT License

213 stars 36 forks source link

[paperwork] take node: prefix as indicator for being a core module #88

Closed netlify-team-account-1 closed 3 years ago

netlify-team-account-1 commented 3 years ago

precinct.paperwork checks node.js modules using the (deprecated) process.binding API. This can be brittle when building & running on different versions of Node.js. This PR makes it a bit more reliable, by adding the node: protocol as a built-in indicator.

cc https://github.com/netlify/zip-it-and-ship-it/pull/746

benmccann commented 3 years ago

@mrjoelkemp any chance you could take a peek at this one?

mrjoelkemp commented 3 years ago

Thanks @netlify-team-account-1! Appreciate the contribution. Released this in a minor version.