search

depfu / feedback

🤔 Question, bugs and feedback for Depfu
https://depfu.com
MIT License
8 stars 4 forks source link

Have the diff of the gems somewhere visible in the PR #48

Closed vpereira closed 2 years ago

vpereira commented 3 years ago

I use daily depfu and it's awesome.

To be able to really review the changes being introduced, I would like to have the diff between the gems visible somewhere in the PR, for example as comment in the PR or a link to the diff in my repository dashboard

theflow commented 3 years ago

Hi @vpereira, not quite sure I follow? You mean the diff of your Gemfile? Or the code changes in the gems themselves? We do already link to the GitHub diff view in most cases. For some gems we can't find the info for various reason, maybe it's one of those?

vpereira commented 3 years ago

Hi @theflow I mean the code changes in the gems themselves. Something like https://github.com/hennevogel/rg-poc/pull/2 or something more elaborated like https://my.diffend.io/gems/solaris-kstat/1.1.1/1.1.2

theflow commented 3 years ago

So what more do you want to see if we take https://github.com/hennevogel/rg-poc/pull/2 as an example? It already includes the list of commits, and if you click through it goes to the compare view which allows you to code review the diff.

vpereira commented 3 years ago

So what more do you want to see if we take hennevogel/rg-poc#2 as an example? It already includes the list of commits, and if you click through it goes to the compare view which allows you to code review the diff.

Hi @theflow, I don't know if you scrolled his PR down, but if you read https://github.com/hennevogel/rg-poc/pull/2#issuecomment-706135912 (to show the important part) we have the list of files, meta data, diff per file, SHA1 from each file, etc.