search

dephell / dephell_archive

Pathlib for archives
MIT License
1 stars 6 forks source link

Fix zip dirs #13

Closed jayvdb closed 4 years ago

jayvdb commented 4 years ago

Fixes https://github.com/dephell/dephell_archive/issues/8

jayvdb commented 4 years ago

Split off from https://github.com/dephell/dephell_archive/pull/6

jayvdb commented 4 years ago

I'll try to solve the other known problem in this PR at https://github.com/dephell/dephell_archive/issues/8#issuecomment-569041012 .

Note the dnspython sdist zip is note important - I could use a much smaller one instead as it is a normal zip without dir entries, and that use case is even covered by the existing .whl file.

orsinium commented 4 years ago

Great! Thanks :)

I would be also happier, maybe even happier, to have the virtual dirs only implemented in ArchivePath, and not in ArchiveStream.

It makes sense but I'm not sure if we should split this logic by 2 places. Let's let ArchiveStream do decisions about the archive content.