search

dephell / dephell_discover

Find project modules and data files (packages and package_data for setup.py).
MIT License
3 stars 5 forks source link

I want to be able to include package_data without an extension #14

Open jochenparm opened 4 years ago

jochenparm commented 4 years ago

I'm having an issue with including a couple of files that I explicitly mention in my pyproject.toml but that don't end up in the package_data list of the converted setup.py

After a lot of trial and error, I started looking into how dephell actually identifies the files to be included. It appears that you're making the assumption that files without an extension are to be ignored.

Would you consider adapting this behavior? As far as I know, it's not bad practice to allow for files without an extension to be packaged up.

https://github.com/dephell/dephell_discover/blob/2ca2890270eb5c84ca4b9f46d00f19e47d5e2cac/dephell_discover/_root.py#L68

jochenparm commented 4 years ago

Can someone give me some feedback? It's easy enough to create a PR that fixes this, but I suppose that there might be a reason that it was implemented like this initially?

orsinium commented 4 years ago

Sure, feel free to contribute.

jochenparm commented 4 years ago

@orsinium Can you have a look at the PR and let me know if it needs additional work?