search

dephell / dephell_discover

Find project modules and data files (packages and package_data for setup.py).
MIT License
3 stars 5 forks source link

python 3.8 compat: ast.Str is deprecated and should use ast.Constant #9

Closed eli-schwartz closed 4 years ago

eli-schwartz commented 4 years ago

They are no longer the same types, and therefore the tests fail.

Fixes #8

eli-schwartz commented 4 years ago

CI fails due to the rather useless statement that /opt/python/3.6/bin/python no longer exists. I blame https://github.com/dephell/dephell_discover/blob/6de1763e095f192da85c1bbe4d10ae6a63a46c6e/.travis.yml#L10

This is locally tested using python 3.7 and python 3.8, so once travis gets unbroken, the CI should pass again.

orsinium commented 4 years ago

I was hoping I can avoid compatibility code if I drop Python 2.7 support at all, and here we are again :upside_down_face:

Thank you! I've changed it a little bit. It's not the only a new type, but also a new name for the attribute (value instead of s and n)

eli-schwartz commented 4 years ago

Thanks! And yeah, fun times on the compatibility code... purportedly this change was supposed to be "deprecated on 3.8 but it won't stop working until 3.9 so you have time to upgrade". So much for that...

eli-schwartz commented 4 years ago

So I tried building this and it doesn't work:

running install_egg_info
error: error in 'egg_base' option: '' does not exist or is not a directory
orsinium commented 4 years ago

Fixed in #11