search

dephell / dephell_links

Parse dependency links
MIT License
0 stars 2 forks source link

VCS specifier #1

Open jayvdb opened 5 years ago

jayvdb commented 5 years ago

I see you have git specifiers.

It might be useful to use https://github.com/retr0h/git-url-parse to help with parsing. Despite saying it is not maintained, coala developers havent had problems getting PRs reviewed and merged, and we dont see many types of git URLs which it fails to correctly parse. (We tried most of the others we could find, and they were worse..)

But, there is also a need for hg+, svn+, etc Not as sexy as git, but still needed for compatibility with pip, and likely others.

jayvdb commented 5 years ago

Hmm, this might be more applicable over at https://github.com/dephell/dephell_links/blob/master/dephell_links/_vcs.py

orsinium commented 5 years ago

Yes, this magic happens in dephell_links.

That's not crucial, because DepHell itself doesn't support hg/svn/etc. Same for poetry. And svn support sounds like a task with the lowest priority overall.

orsinium commented 5 years ago

I've moved the issue and left it open. Will do if someone needs it.

jayvdb commented 5 years ago

Re svn, fair enough, few people need it.

However I am in need of hg support, due to a few repos there that old timer python people refuse to move (or maintain properly, and refuse to use hg evolve, grrr). I'll see how I go.

orsinium commented 5 years ago

If you need this support only from dephell_links, it's easy to do. If you need this support in the whole dephell, I can't afford it to myself. Of course, I'll be happy to review and merge your PR if you make svn repository support for dephell like now git repo is implemented.

orsinium commented 5 years ago

I'm not going to refuse any features people need, but I cannot afford myself to implement least important things.